Skip to content

Conversation

fredden
Copy link

@fredden fredden commented Apr 23, 2024

When working with this repository as a developer, we should be using the latest compatible packages. By writing a lock file for Composer, we may get into a state where we are "stuck" on an older version of a dependency. This change avoids such a situation by telling Composer to not write out a lock file in the project.

Copy link
Collaborator

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would like to see a passing build.

I will rebase this PR after #174 has been merged to confirm, though I expect the build to pass without issues.

@jrfnl jrfnl added this to the 1.4.x Next milestone Apr 24, 2024
Copy link
Member

@grogy grogy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, thank you. I will merge it.

@jrfnl jrfnl force-pushed the feature/composer.lock-false branch from 73c7e03 to fa55266 Compare May 20, 2024 10:18
@grogy grogy merged commit 0c27060 into php-parallel-lint:develop May 20, 2024
@fredden fredden deleted the feature/composer.lock-false branch May 20, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants